Compare commits

...

12 Commits

Author SHA1 Message Date
yasirkula 8cc7798f17 Fixed a rare ArgumentNullException when searching an Animation/Animator component (#28) 2021-09-26 12:33:44 +03:00
yasirkula 45b0f6f1d9 Version 1.9.7 2021-07-25 18:00:33 +03:00
yasirkula c599ea6273 Duplicate asset usage descriptions in search results page are now omitted (i.e. "[Usage information][Usage information] Some asset" becomes "[Usage information] Some asset") 2021-07-25 17:49:30 +03:00
yasirkula 7ba33e2d4e When an asset in "Find references of:" list is right clicked, Refresh button appears which refreshes that asset's sub-assets list 2021-07-25 17:39:12 +03:00
yasirkula ac294324dd When a folder is assigned to a sprite atlas, all sprites in that folder are searched 2021-07-25 17:23:17 +03:00
yasirkula 8dc7d5508b ParticleSystem's Sub Emitters module is now searched correctly 2021-07-25 17:22:00 +03:00
Nika Burimenko c9131811e2 Sprites assigned to Particle System's Texture Sheet Animation Module are now detected (#26)
Fixed Sprite within Particle System's Texture Sheet Animation not being detected

Authored-by: Nika Burimenko <remedy89@gmail.com>
2021-07-25 16:37:44 +03:00
yasirkula 133b8b1227 Fixed small text issue on 2019.1 and 2019.2 (some devices might not have been affected by this issue) 2021-07-06 17:49:31 +03:00
yasirkula 1db9dbf9b0 Fixed issues with mysterious empty dependencies returned by AssetDatabase.GetDependencies 2021-06-09 12:35:25 +03:00
yasirkula a6b0f5ae92 Unity 2020 support 2021-05-18 13:47:38 +03:00
Süleyman Yasir KULA 8e7369e44e Some properties in Project Settings like "Quality Settings->SRP Asset" weren't included in search, fixed 2021-03-28 19:57:44 +03:00
Süleyman Yasir KULA 7b60eeacf7 If an exception occurs while searching for references via reflection, the problematic object will be skipped and a warning will be logged to the console instead of interrupting the whole search 2021-03-17 16:13:24 +03:00
7 changed files with 217 additions and 60 deletions
@@ -547,45 +547,10 @@ namespace AssetUsageDetectorNamespace
}
catch( Exception e )
{
StringBuilder sb = new StringBuilder( objectsToSearchSet.Count * 50 + callStack.Count * 50 + 500 );
StringBuilder sb = new StringBuilder( objectsToSearchSet.Count * 50 + callStack.Count * 50 + 1000 );
sb.AppendLine( "<b>AssetUsageDetector Error:</b>" ).AppendLine().Append( e ).AppendLine();
Object latestUnityObjectInCallStack = null;
if( callStack.Count > 0 )
{
sb.AppendLine( "Stack contents: " );
for( int i = callStack.Count - 1; i >= 0; i-- )
{
latestUnityObjectInCallStack = callStack[i] as Object;
if( latestUnityObjectInCallStack )
{
if( !AssetDatabase.Contains( latestUnityObjectInCallStack ) )
{
string scenePath = AssetDatabase.GetAssetOrScenePath( latestUnityObjectInCallStack );
if( !string.IsNullOrEmpty( scenePath ) && SceneManager.GetSceneByPath( scenePath ).IsValid() )
sb.Append( "Scene: " ).AppendLine( scenePath );
}
break;
}
}
for( int i = callStack.Count - 1; i >= 0; i-- )
{
sb.Append( i ).Append( ": " );
Object unityObject = callStack[i] as Object;
if( unityObject )
sb.Append( unityObject.name ).Append( " (" ).Append( unityObject.GetType() ).AppendLine( ")" );
else if( callStack[i] != null )
sb.Append( callStack[i].GetType() ).AppendLine( " object" );
else
sb.AppendLine( "<<destroyed>>" );
}
sb.AppendLine();
}
Object latestUnityObjectInCallStack = AppendCallStackToStringBuilder( sb );
sb.AppendLine( "Searching references of: " );
foreach( Object obj in objectsToSearchSet )
@@ -635,7 +600,9 @@ namespace AssetUsageDetectorNamespace
if( shouldOpenPrefabStageWithoutContext )
#endif
AssetDatabase.OpenAsset( AssetDatabase.LoadAssetAtPath<GameObject>( openPrefabStageAssetPath ) );
{
AssetDatabase.OpenAsset( AssetDatabase.LoadAssetAtPath<GameObject>( openPrefabStageAssetPath ) );
}
}
#endif
}
@@ -1106,5 +1073,48 @@ namespace AssetUsageDetectorNamespace
Object.DestroyImmediate( temp );
}
}
// Appends contents of callStack to StringBuilder and returns the most recent Unity object in callStack
private Object AppendCallStackToStringBuilder( StringBuilder sb )
{
Object latestUnityObjectInCallStack = null;
if( callStack.Count > 0 )
{
sb.AppendLine().AppendLine( "Stack contents: " );
for( int i = callStack.Count - 1; i >= 0; i-- )
{
latestUnityObjectInCallStack = callStack[i] as Object;
if( latestUnityObjectInCallStack )
{
if( !AssetDatabase.Contains( latestUnityObjectInCallStack ) )
{
string scenePath = AssetDatabase.GetAssetOrScenePath( latestUnityObjectInCallStack );
if( !string.IsNullOrEmpty( scenePath ) && SceneManager.GetSceneByPath( scenePath ).IsValid() )
sb.Append( "Scene: " ).AppendLine( scenePath );
}
break;
}
}
for( int i = callStack.Count - 1; i >= 0; i-- )
{
sb.Append( i ).Append( ": " );
Object unityObject = callStack[i] as Object;
if( unityObject )
sb.Append( unityObject.name ).Append( " (" ).Append( unityObject.GetType() ).AppendLine( ")" );
else if( callStack[i] != null )
sb.Append( callStack[i].GetType() ).AppendLine( " object" );
else
sb.AppendLine( "<<destroyed>>" );
}
sb.AppendLine();
}
return latestUnityObjectInCallStack;
}
}
}
@@ -51,10 +51,35 @@ namespace AssetUsageDetectorNamespace
if( fileSizes == null || fileSizes.Length != dependencies.Length )
fileSizes = new long[dependencies.Length];
for( int i = 0; i < dependencies.Length; i++ )
int length = dependencies.Length;
for( int i = 0; i < length; i++ )
{
FileInfo assetFile = new FileInfo( dependencies[i] );
fileSizes[i] = assetFile.Exists ? assetFile.Length : 0L;
if( !string.IsNullOrEmpty( dependencies[i] ) )
{
FileInfo assetFile = new FileInfo( dependencies[i] );
fileSizes[i] = assetFile.Exists ? assetFile.Length : 0L;
}
else
{
// This dependency is empty which causes issues when passed to FileInfo constructor
// Find a non-empty dependency and move it to this index
for( int j = length - 1; j > i; j--, length-- )
{
if( !string.IsNullOrEmpty( dependencies[j] ) )
{
dependencies[i--] = dependencies[j];
break;
}
}
length--;
}
}
if( length != fileSizes.Length )
{
Array.Resize( ref dependencies, length );
Array.Resize( ref fileSizes, length );
}
}
}
@@ -3,6 +3,7 @@ using System.Collections.Generic;
using System.Collections;
using System.IO;
using System.Reflection;
using System.Text;
using UnityEditor;
using UnityEditor.Animations;
using UnityEngine;
@@ -399,7 +400,11 @@ namespace AssetUsageDetectorNamespace
try
{
ParticleSystem.CollisionModule collisionModule = particleSystem.collision;
#if UNITY_2020_2_OR_NEWER
for( int i = 0, j = collisionModule.planeCount; i < j; i++ )
#else
for( int i = 0, j = collisionModule.maxPlaneCount; i < j; i++ )
#endif
referenceNode.AddLinkTo( SearchObject( collisionModule.GetPlane( i ) ), "Collision Module: Plane" );
}
catch { }
@@ -407,10 +412,35 @@ namespace AssetUsageDetectorNamespace
try
{
ParticleSystem.TriggerModule triggerModule = particleSystem.trigger;
#if UNITY_2020_2_OR_NEWER
for( int i = 0, j = triggerModule.colliderCount; i < j; i++ )
#else
for( int i = 0, j = triggerModule.maxColliderCount; i < j; i++ )
#endif
referenceNode.AddLinkTo( SearchObject( triggerModule.GetCollider( i ) ), "Trigger Module: Collider" );
}
catch { }
#if UNITY_2017_1_OR_NEWER
try
{
ParticleSystem.TextureSheetAnimationModule textureSheetAnimationModule = particleSystem.textureSheetAnimation;
for( int i = 0, j = textureSheetAnimationModule.spriteCount; i < j; i++ )
referenceNode.AddLinkTo( SearchObject( textureSheetAnimationModule.GetSprite( i ) ), "Texture Sheet Animation Module: Sprite" );
}
catch { }
#endif
#if UNITY_5_5_OR_NEWER
try
{
ParticleSystem.SubEmittersModule subEmittersModule = particleSystem.subEmitters;
for( int i = 0, j = subEmittersModule.subEmittersCount; i < j; i++ )
referenceNode.AddLinkTo( SearchObject( subEmittersModule.GetSubEmitterSystem( i ) ), "Sub Emitters Module: ParticleSystem" );
}
catch { }
#endif
}
else if( searchRenderers && component is Renderer )
{
@@ -714,19 +744,61 @@ namespace AssetUsageDetectorNamespace
if( packables != null )
{
for( int i = 0; i < packables.Length; i++ )
referenceNode.AddLinkTo( SearchObject( packables[i] ), "Packed Texture" );
SearchSpriteAtlas( referenceNode, packables[i] );
}
#else
SerializedProperty packables = spriteAtlasSO.FindProperty( "m_EditorData.packables" );
if( packables != null )
{
for( int i = 0, length = packables.arraySize; i < length; i++ )
referenceNode.AddLinkTo( SearchObject( packables.GetArrayElementAtIndex( i ).objectReferenceValue ), "Packed Texture" );
SearchSpriteAtlas( referenceNode, packables.GetArrayElementAtIndex( i ).objectReferenceValue );
}
#endif
return referenceNode;
}
private void SearchSpriteAtlas( ReferenceNode referenceNode, Object packedAsset )
{
if( packedAsset == null || packedAsset.Equals( null ) )
return;
referenceNode.AddLinkTo( SearchObject( packedAsset ), "Packed Texture" );
if( packedAsset is Texture )
{
// Search the Texture's sprites if the Texture asset isn't included in the "Find references of:" list (i.e. user has
// added only a Sprite sub-asset of the Texture to the list, not the Texture asset itself). Otherwise, references to
// both the Texture and its sprites will be found which can be considered as duplicate references
if( AssetDatabase.IsMainAsset( packedAsset ) && !assetsToSearchSet.Contains( packedAsset ) )
{
Object[] textureSubAssets = AssetDatabase.LoadAllAssetRepresentationsAtPath( AssetDatabase.GetAssetPath( packedAsset ) );
for( int i = 0; i < textureSubAssets.Length; i++ )
{
if( textureSubAssets[i] is Sprite )
referenceNode.AddLinkTo( SearchObject( textureSubAssets[i] ), "Packed Texture" );
}
}
}
else if( packedAsset.IsFolder() )
{
// Search all Sprites in the folder
string[] texturesInFolder = AssetDatabase.FindAssets( "t:Texture2D", new string[] { AssetDatabase.GetAssetPath( packedAsset ) } );
if( texturesInFolder != null )
{
for( int i = 0; i < texturesInFolder.Length; i++ )
{
string texturePath = AssetDatabase.GUIDToAssetPath( texturesInFolder[i] );
TextureImporter textureImporter = AssetImporter.GetAtPath( texturePath ) as TextureImporter;
if( textureImporter != null && textureImporter.textureType == TextureImporterType.Sprite )
{
// Search the Texture and its sprites
SearchSpriteAtlas( referenceNode, AssetDatabase.LoadMainAssetAtPath( texturePath ) );
}
}
}
}
}
#endif
#if UNITY_2017_3_OR_NEWER
@@ -908,6 +980,9 @@ namespace AssetUsageDetectorNamespace
for( int i = 0; i < clips.Length; i++ )
{
AnimationClip clip = clips[i];
if( !clip )
continue;
bool isClipUnique = true;
for( int j = i - 1; j >= 0; j-- )
{
@@ -1020,26 +1095,38 @@ namespace AssetUsageDetectorNamespace
SerializedProperty iteratorVisible = so.GetIterator();
if( iterator.Next( true ) )
{
string assetPath = AssetDatabase.GetAssetPath( (Object) referenceNode.nodeObject );
bool isProjectSettings = !string.IsNullOrEmpty( assetPath ) && assetPath.StartsWithFast( "ProjectSettings/" );
bool iteratingVisible = iteratorVisible.NextVisible( true );
bool enterChildren;
do
{
// Iterate over NextVisible properties AND the properties that have corresponding FieldInfos (internal Unity
// properties don't have FieldInfos so we are skipping them, which is good because search results found in
// those properties aren't interesting and mostly confusing)
bool isVisible = iteratingVisible && SerializedProperty.EqualContents( iterator, iteratorVisible );
if( isVisible )
iteratingVisible = iteratorVisible.NextVisible( true );
if( isProjectSettings )
{
// Search Project Settings in full because for some reason, important settings like SRP asset
// slot in Quality Settings aren't searched when iterating over only visible properties
enterChildren = true;
}
else
{
Type propFieldType;
isVisible = iterator.type == "Array" || fieldInfoGetter( iterator, out propFieldType ) != null;
}
// Iterate over NextVisible properties AND the properties that have corresponding FieldInfos (internal Unity
// properties don't have FieldInfos so we are skipping them, which is good because search results found in
// those properties aren't interesting and mostly confusing)
bool isVisible = iteratingVisible && SerializedProperty.EqualContents( iterator, iteratorVisible );
if( isVisible )
iteratingVisible = iteratorVisible.NextVisible( true );
else
{
Type propFieldType;
isVisible = iterator.type == "Array" || fieldInfoGetter( iterator, out propFieldType ) != null;
}
if( !isVisible )
{
enterChildren = false;
continue;
if( !isVisible )
{
enterChildren = false;
continue;
}
}
ReferenceNode searchResult;
@@ -1101,7 +1188,7 @@ namespace AssetUsageDetectorNamespace
try
{
object variableValue = variables[i].Get( referenceNode.nodeObject );
if( variableValue == null )
if( variableValue == null || variableValue.Equals( null ) )
continue;
// Values stored inside ICollection objects are searched using IEnumerable,
@@ -1132,6 +1219,15 @@ namespace AssetUsageDetectorNamespace
catch( MissingReferenceException ) { }
catch( MissingComponentException ) { }
catch( NotImplementedException ) { }
catch( Exception e )
{
// Unknown exceptions usually occur when variableValue is an IEnumerable and its enumerator throws an unhandled exception in MoveNext or Current
StringBuilder sb = new StringBuilder( callStack.Count * 50 + 1000 );
sb.Append( "Skipped searching " ).Append( referenceNode.nodeObject.GetType().FullName ).Append( "." ).Append( variables[i].name ).AppendLine( " because it threw exception:" ).Append( e ).AppendLine();
Object latestUnityObjectInCallStack = AppendCallStackToStringBuilder( sb );
Debug.LogWarning( sb.ToString(), latestUnityObjectInCallStack );
}
}
}
@@ -86,12 +86,18 @@ namespace AssetUsageDetectorNamespace
Object prevObject = GetObjectFromElement( element );
Object newObject = EditorGUILayout.ObjectField( "", prevObject, typeof( Object ), acceptSceneObjects );
if( GUI.changed && prevObject != newObject )
if( GUI.changed )
{
hasChanged = true;
SetObjectOfElement( list, i, newObject );
}
if( guiEnabled && newObject && ev.type == EventType.ContextClick && GUILayoutUtility.GetLastRect().Contains( ev.mousePosition ) )
{
OnElementRightClicked( list, i, newObject );
ev.Use();
}
if( guiEnabled )
{
if( GUILayout.Button( "+", Utilities.GL_WIDTH_25 ) )
@@ -121,6 +127,7 @@ namespace AssetUsageDetectorNamespace
protected abstract T CreateElement( Object source );
protected abstract Object GetObjectFromElement( T element );
protected abstract void SetObjectOfElement( List<T> list, int index, Object value );
protected abstract void OnElementRightClicked( List<T> list, int index, Object value );
protected abstract bool IsElementNull( T element );
protected abstract void PostElementDrawer( T element );
}
@@ -146,6 +153,10 @@ namespace AssetUsageDetectorNamespace
list[index] = value;
}
protected override void OnElementRightClicked( List<Object> list, int index, Object value )
{
}
protected override bool IsElementNull( Object element )
{
return element == null || element.Equals( null );
@@ -178,6 +189,13 @@ namespace AssetUsageDetectorNamespace
list[index].RefreshSubAssets();
}
protected override void OnElementRightClicked( List<ObjectToSearch> list, int index, Object value )
{
GenericMenu contextMenu = new GenericMenu();
contextMenu.AddItem( new GUIContent( "Refresh" ), false, () => SetObjectOfElement( list, index, value ) );
contextMenu.ShowAsContext();
}
protected override bool IsElementNull( ObjectToSearch element )
{
return element == null || element.obj == null || element.obj.Equals( null );
@@ -924,7 +924,11 @@ namespace AssetUsageDetectorNamespace
if( !string.IsNullOrEmpty( description ) )
{
if( !string.IsNullOrEmpty( links[i].description ) )
links[i] = new Link( links[i].targetNode, string.Concat( links[i].description, Environment.NewLine, description ) );
{
// Avoid duplicate descriptions
if( !links[i].description.Contains( description ) )
links[i] = new Link( links[i].targetNode, string.Concat( links[i].description, Environment.NewLine, description ) );
}
else
links[i] = new Link( links[i].targetNode, description );
}
@@ -88,7 +88,11 @@ namespace AssetUsageDetectorNamespace
m_boxGUIStyle.focused.textColor = textColor;
m_boxGUIStyle.active.textColor = textColor;
#if !UNITY_2019_1_OR_NEWER || UNITY_2019_3_OR_NEWER
// On 2019.1 and 2019.2 versions, GUI.skin.button.fontSize returns 0 on some devices
// https://forum.unity.com/threads/asset-usage-detector-find-references-to-an-asset-object-open-source.408134/page-3#post-7285954
m_boxGUIStyle.fontSize = ( m_boxGUIStyle.fontSize + GUI.skin.button.fontSize ) / 2;
#endif
}
return m_boxGUIStyle;
+1 -1
View File
@@ -1,7 +1,7 @@
{
"name": "com.yasirkula.assetusagedetector",
"displayName": "Asset Usage Detector",
"version": "1.9.1",
"version": "1.9.8",
"documentationUrl": "https://github.com/yasirkula/UnityAssetUsageDetector",
"changelogUrl": "https://github.com/yasirkula/UnityAssetUsageDetector/releases",
"licensesUrl": "https://github.com/yasirkula/UnityAssetUsageDetector/blob/master/LICENSE.txt",