From 96709d760941238972abb034b56a9fb55b6a8ebc Mon Sep 17 00:00:00 2001 From: James Chen Date: Fri, 13 Oct 2017 17:45:08 +0800 Subject: [PATCH] Fixes wrong usage of assert macro in jsb_creator_manual.cpp. --- .../js-bindings/manual/jsb_creator_manual.cpp | 14 ++++++++------ 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/native/cocos/scripting/js-bindings/manual/jsb_creator_manual.cpp b/native/cocos/scripting/js-bindings/manual/jsb_creator_manual.cpp index bf40d96d63..d07dc6cf17 100644 --- a/native/cocos/scripting/js-bindings/manual/jsb_creator_manual.cpp +++ b/native/cocos/scripting/js-bindings/manual/jsb_creator_manual.cpp @@ -316,7 +316,6 @@ SE_BIND_FUNC(js_creator_sp_initSkeletonRenderer) bool register_all_creator_manual(se::Object* obj) { - // Physics __jsb_creator_PhysicsContactListener_proto->defineFunction("setPreSolve", _SE(js_creator_PhysicsContactListener_setPreSolve)); @@ -333,11 +332,14 @@ bool register_all_creator_manual(se::Object* obj) // Spine se::Value nsVal; - assert(obj->getProperty("sp", &nsVal)); - se::Object* ns = nsVal.toObject(); - - ns->defineFunction("_initSkeletonRenderer", _SE(js_creator_sp_initSkeletonRenderer)); - + if (obj->getProperty("sp", &nsVal) && nsVal.isObject()) + { + nsVal.toObject()->defineFunction("_initSkeletonRenderer", _SE(js_creator_sp_initSkeletonRenderer)); + } + else + { + CCLOGERROR("Couldn't get window.sp varible, was sp module registered?"); + } se::ScriptEngine::getInstance()->clearException();