From 4cdda1e2cfa2c0ca2b7a863f2e6089418e2d6b0c Mon Sep 17 00:00:00 2001 From: Ling Zhan Date: Mon, 5 Dec 2022 17:25:44 +0800 Subject: [PATCH] [fix] builtin-2d-physics removeShape() slow #12843 (#13650) * [fix] builtin-2d-physics removeShape() slow #12843 # Conflicts: # cocos/physics-2d/builtin/builtin-world.ts * [fix] builtin-2d-physics removeShape() slow #12843 * Revert "[fix] builtin-2d-physics removeShape() slow #12843" This reverts commit d42ea68d743ad5e343544719426a9e8beffc14e8. --- cocos/physics-2d/builtin/builtin-world.ts | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cocos/physics-2d/builtin/builtin-world.ts b/cocos/physics-2d/builtin/builtin-world.ts index 68b838788b..8afe04e665 100644 --- a/cocos/physics-2d/builtin/builtin-world.ts +++ b/cocos/physics-2d/builtin/builtin-world.ts @@ -11,6 +11,7 @@ import { EPhysics2DDrawFlags, Contact2DType, ERaycast2DType, RaycastResult2D } f import { PhysicsSystem2D, Collider2D } from '../framework'; import { BuiltinContact } from './builtin-contact'; import { legacyCC } from '../../core/global-exports'; +import { fastRemoveAt } from '../../core/utils/array'; const contactResults: BuiltinContact[] = []; const testIntersectResults: Collider2D[] = []; @@ -57,8 +58,7 @@ export class BuiltinPhysicsWorld implements IPhysicsWorld { const shapes = this._shapes; const index = shapes.indexOf(shape); if (index >= 0) { - shapes.splice(index, 1); - + fastRemoveAt(shapes, index); const contacts = this._contacts; for (let i = contacts.length - 1; i >= 0; i--) { const contact = contacts[i]; @@ -67,7 +67,7 @@ export class BuiltinPhysicsWorld implements IPhysicsWorld { this._emitCollide(contact, Contact2DType.END_CONTACT); } - contacts.splice(i, 1); + fastRemoveAt(contacts, i); } } }