From 83128ebb09305e4c15a58968a94550179e96ffac Mon Sep 17 00:00:00 2001 From: mob-sakai <12690315+mob-sakai@users.noreply.github.com> Date: Thu, 17 Jul 2025 18:36:17 +0900 Subject: [PATCH] fix: draw calls increase even when using `UIEffectReplica` The `UIEffectReplica` component reuses materials as much as possible without creating new ones. close #364 --- Packages/src/Runtime/UIEffectReplica.cs | 31 ++++++++++++++++++++----- 1 file changed, 25 insertions(+), 6 deletions(-) diff --git a/Packages/src/Runtime/UIEffectReplica.cs b/Packages/src/Runtime/UIEffectReplica.cs index b98e711..9005579 100644 --- a/Packages/src/Runtime/UIEffectReplica.cs +++ b/Packages/src/Runtime/UIEffectReplica.cs @@ -99,7 +99,12 @@ namespace Coffee.UIEffects public override bool canModifyShape => m_AllowToModifyMeshShape; - public override uint effectId => target ? target.effectId : 0; + public override uint effectId => target + ? target.effectId + : preset + ? (uint)preset.GetInstanceID() + : (uint)GetInstanceID(); + public override UIEffectContext context { @@ -115,11 +120,25 @@ namespace Coffee.UIEffects } } - public override RectTransform transitionRoot => useTargetTransform && isTargetInScene - ? target.transitionRoot - : m_CustomRoot - ? m_CustomRoot - : transform as RectTransform; + public override RectTransform transitionRoot + { + get + { + if (preset && useTargetTransform && !m_CustomRoot && graphic && graphic.canvas) + { + return graphic.canvas.transform as RectTransform; + } + + if (useTargetTransform && isTargetInScene) + { + return target.transitionRoot; + } + + return m_CustomRoot + ? m_CustomRoot + : transform as RectTransform; + } + } private bool isTargetInScene => target && target.gameObject.scene.IsValid();